Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup doc testing #3205

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Cleanup doc testing #3205

merged 1 commit into from
Aug 16, 2024

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Aug 15, 2024

What's this all about?

Removes the duplicate doctests. I kept the cargo doc to ensure the documentation always builds.

Fixes: #3204

@kennykerr
Copy link
Collaborator

And presumably we can revert the changes to lib.rs for both windows and windows-sys.

@Nerixyz
Copy link
Contributor Author

Nerixyz commented Aug 15, 2024

And presumably we can revert the changes to lib.rs for both windows and windows-sys.

We could. My thinking behind the change was that the readmes now have links to the samples and the feature search, both of which have a version number in them.

@kennykerr kennykerr merged commit 0e1671c into microsoft:master Aug 16, 2024
1 check passed
@Nerixyz Nerixyz deleted the doc/cleanup-test branch August 16, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up doc testing
2 participants